Repository navigation
Fix #1935: pin Playwright jobs to ubuntu-24.04; skip browser steps after a failed install - #1936
Merged
Merged
Conversation
…ns tests after a failed browser install ubuntu-latest rolled to ubuntu-26.04, where Playwright 1.59.x has no Chromium build (support landed in 1.61). The Decisions tab step's !cancelled() gate also ran it after the install failed, burying the cause under launch errors.
…n no browser step after a failed install
…cluesmith scoped registry Adjacent test bug found while running the suite: a ~/.npmrc @cluesmith:registry outranks npm_config_registry, so the 'unreachable registry' test reached npmjs and got a real version.
amrmelsayed
added a commit
that referenced
this pull request
Nov 20, 2026
amrmelsayed
added a commit
that referenced
this pull request
Nov 20, 2026
amrmelsayed
added a commit
that referenced
this pull request
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub's
ubuntu-latestrolled to Ubuntu 26.04, where the Playwright this repo resolves (1.59.1) has no Chromium build, soplaywright install chromiumfails and every browser test with it. This pins the three Playwright jobs toubuntu-24.04. The Decisions tab step no longer runs when the browser install failed.Fixes #1935
Root Cause
ubuntu-24.04. Run 44485513618 (2026-11-19) ran onubuntu-26.04(20261111.196.1) and failed at the install step withPlaywright does not support chromium on ubuntu26.04-x64.ubuntu26.04-x64entry. 1.61.0 and later (up to the latest stable, 1.65.1) have one. Bumping Playwright is a real alternative, but it means a dependency change and a jump in the Chromium revision. Pinning the runner is the smallest change that makes CI deterministic.bash -e, exit 1), andRun Playwright testswas skipped. The dozens of launch errors came fromRun Decisions tab tests. Itsif: ${{ !cancelled() }}, which is meant to let it run even when the main suite fails, also let it run with no browser installed.Fix
dashboard-e2e.yml(playwright),test.yml(canvas-browser,web-browser): changedruns-on: ubuntu-latesttoubuntu-24.04, with a CI: Playwright jobs fail on ubuntu-latest after the runner moved to Ubuntu 26.04 (no Chromium build); pin the runner and fail the install step #1935 comment. The comment says to move the pin only together with a Playwright bump (1.61 or later) that has been verified on the new image.dashboard-e2e.yml: the install step now hasid: install-browsers. The Decisions step's condition is now!cancelled() && steps.install-browsers.outcome == 'success', so a missing browser is reported once, at the install step.protocol-drift-audit.test.ts, test "REAL default lookup is offline-tolerant": it failed every time on a machine whose~/.npmrcsets@cluesmith:registry=, because a scoped registry takes precedence overnpm_config_registry. The test now overrides the scoped key as well.Test Plan
bugfix-1935-playwright-runner-pin.test.tsscans every workflow for jobs that runplaywright install. It asserts that each such job runs on a pinnedubuntu-X.Yimage, and that no step after the install with an!cancelled(),always()orfailure()condition can run when the install failed. Against HEAD's workflows 4 assertions fail; with the fix all 7 pass.canvas-browserandweb-browserjobs pass on this PR (run 44718195533)workflow_dispatch(run 44718205786: install, Playwright and Decisions steps all succeed on ubuntu-24.04)mainafter mergeCMAP
agyexited with code 1; non-blocking)chore(porch):commits lack the[Bugfix #1935]prefix. Porch writes these on every builder branch, so they are left unchanged. Codex called the fix and test otherwise focused and correct.fetchLatestVersionhardcodes the package literal. Its follow-up suggestion: bump Playwright to 1.61 or later and remove the pin beforeubuntu-24.04is retired.