Skip to content

Fix #1935: pin Playwright jobs to ubuntu-24.04; skip browser steps after a failed install - #1936

Merged
amrmelsayed merged 11 commits into
mainfrom
builder/bugfix-1935
Nov 20, 2026
Merged

amrmelsayed merged 11 commits into
mainfrom
builder/bugfix-1935

Conversation

@amrmelsayed

@amrmelsayed amrmelsayed commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

GitHub's ubuntu-latest rolled to Ubuntu 26.04, where the Playwright this repo resolves (1.59.1) has no Chromium build, so playwright install chromium fails and every browser test with it. This pins the three Playwright jobs to ubuntu-24.04. The Decisions tab step no longer runs when the browser install failed.

Fixes #1935

Root Cause

  • Run 44264876229 (2026-11-18) ran on image ubuntu-24.04. Run 44485513618 (2026-11-19) ran on ubuntu-26.04 (20261111.196.1) and failed at the install step with Playwright does not support chromium on ubuntu26.04-x64.
  • I checked the published playwright-core tarballs. 1.60.0 has no ubuntu26.04-x64 entry. 1.61.0 and later (up to the latest stable, 1.65.1) have one. Bumping Playwright is a real alternative, but it means a dependency change and a jump in the Chromium revision. Pinning the runner is the smallest change that makes CI deterministic.
  • Correction to the issue: the install step already failed its own step (bash -e, exit 1), and Run Playwright tests was skipped. The dozens of launch errors came from Run Decisions tab tests. Its if: ${{ !cancelled() }}, which is meant to let it run even when the main suite fails, also let it run with no browser installed.

Fix

Test Plan

  • Regression test bugfix-1935-playwright-runner-pin.test.ts scans every workflow for jobs that run playwright install. It asserts that each such job runs on a pinned ubuntu-X.Y image, and that no step after the install with an !cancelled(), always() or failure() condition can run when the install failed. Against HEAD's workflows 4 assertions fail; with the fix all 7 pass.
  • Build passes (porch build check)
  • All tests pass (porch tests check; codev suite 8249 passed)
  • The canvas-browser and web-browser jobs pass on this PR (run 44718195533)
  • Dashboard E2E passes on this branch via workflow_dispatch (run 44718205786: install, Playwright and Decisions steps all succeed on ubuntu-24.04)
  • Dashboard E2E passes on main after merge

CMAP

  • gemini: skipped (agy exited with code 1; non-blocking)
  • codex: REQUEST_CHANGES, only because the porch-authored chore(porch): commits lack the [Bugfix #1935] prefix. Porch writes these on every builder branch, so they are left unchanged. Codex called the fix and test otherwise focused and correct.
  • claude: APPROVE. Its test-header nit is addressed. Its other nit (derive the scope from a constant) does not apply: fetchLatestVersion hardcodes the package literal. Its follow-up suggestion: bump Playwright to 1.61 or later and remove the pin before ubuntu-24.04 is retired.

…ns tests after a failed browser install

ubuntu-latest rolled to ubuntu-26.04, where Playwright 1.59.x has no Chromium build (support landed in 1.61). The Decisions tab step's !cancelled() gate also ran it after the install failed, burying the cause under launch errors.
…cluesmith scoped registry

Adjacent test bug found while running the suite: a ~/.npmrc @cluesmith:registry outranks npm_config_registry, so the 'unreachable registry' test reached npmjs and got a real version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Playwright jobs fail on ubuntu-latest after the runner moved to Ubuntu 26.04 (no Chromium build); pin the runner and fail the install step

1 participant